v1.3 and v2.0

wanted to write down what i’ll be prepping in the next few days for posterity so people aren’t waiting unnecessarily for their issues to get resolved.

there’s a couple of issues with the upcoming minor / major versions of graphql-tag, in particular, we want to move graphql-js to be an external dependency and no longer bundled within graphql-tag. however, this is a fairly major change since it will

1. introduce a new, potentially larger set of dependencies from graphql
2. removes two previously exported values from the graphql printer and parse (print and parse, respectively) that others may depend on (in particular, apollo-client, react-apollo, and angular-apollo

however, upgrading the bundled version of graphql within graphql-tag is important since it resolves issues that were resolved upstream like #47. we also want to make sure we’re deprecating the fields we’re removing from the graphql-tag module.

thus, here’s what’s coming in v1.3 and v2.0:

v1.3

v1.3 will contain a bundled version of graphql@^0.9.0, as well as deprecation notices for both print and parse.

• this will resolve #47 for those who want to stay with the bundled version of graphql

v2.0

v2.0 will contain the changes currently in master to move from using the bundled version of graphql to establishing graphql as a peerDependency. we’ll also remove the previously mentioned exports

• this will resolve #49

v1.3 is straightforward and will get done earlier rather than later, and v2.0 may take a little bit of testing to make sure it doesn’t bloat our upstream clients (i’ll start with a beta release of 2.0 and see how it interacts with apollo-client)

/cc @stubailo and @helfer

EDIT: if you’re using one of the deprecated exports, you should use graphql/language/parser and graphql/language/printer moving forward (graphql-tag will be using those too in v2.0)

[timbrandin]

Btw, I still get the warning in the console on the client:

Warning - the `printer` exports from `graphql-tag` will be removed in the next major version.
See https://github.com/apollographql/graphql-tag/issues/54 for more information.

[jnwng]

Ah - I added the deprecation warning for people importing the bundled parser and printer, but guess what: we use it too. I’ll release a patch to silence those errors when ‘graphql-tag’ uses the bundled modules. On Wed, Mar 1, 2017 at 2:20 AM Tim Brandin [e-mail] wrote:

I get these warnings all over now:

W20170301-11:17:42.782(1)? (STDERR) Warning - the parser exports from graphql-tag will be removed in the next major version. W20170301-11:17:42.782(1)? (STDERR) See https://github.com/apollographql/graphql-tag/issues/54 for more information.

But I haven’t imported anything else than this way:

import gql from ‘graphql-tag’;

How do I resolve this?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/apollographql/graphql-tag/issues/54#issuecomment-283301475, or mute the thread https://github.com/notifications/unsubscribe-auth/ABERRtyEmACqMJz92xaHo8lzbabAIlMLks5rhUaAgaJpZM4MKkzS .