question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Is this project willing take pull request of typescript definitions?

See original GitHub issue

It will be useful for typescript users and improve the experiences on some editors like vscode.

basicly a index.d.ts file with:

type Option = {
    rootMargin?: string;
    threshold?: number;
    load?(element: HTMLElement | HTMLCanvasElement): void;
}

type Observer = {
    observe(): void;
}

declare function lozad(selector?: string, options?: Option): Observer;

declare namespace lozad {
    const prototype: {
    };
}

export as namespace lozad;

export = lozad;

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:3
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
thiamsantoscommented, Sep 13, 2017

Never mind. @plantain-00 added the type definitions to DefinitelyTyped/DefinitelyTyped#19712. So that discussion is useless 😄

0reactions
thiamsantoscommented, Sep 13, 2017

@thiamsantos will need to maintain two codebases then, and similarly for requests for any other JS flavour

Actually no, the typescript definitions are not a codebase just the definitions for the types of the arguments.

Read more comments on GitHub >

github_iconTop Results From Across the Web

TypeScript definitions by Silic0nS0ldier · Pull Request #22
Addresses #21 I'm better at working with TypeScript on its own then I am at writing ... Silic0nS0ldier wants to merge 2 commits...
Read more >
Documentation - TypeScript 3.8
For more information about the feature, you can take a look at the pull request, and relevant changes around broadening where imports from...
Read more >
Distribution of TypeScript definiton files - Stack Overflow
If a developer is willing to accept a Pull Request, is it better to have them distributed with the package? If a definition...
Read more >
6.3 GitHub - Maintaining a Project - Git SCM
It will give you a small diffstat — a list of files that have changed in the Pull Request and by how much....
Read more >
Generating TypeScript Definition Files from JavaScript
We took the liberty of publishing a forked version typescript-temporary-fork-for-jsdoc which is just a copy of the above pull request. Generate ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found