Lean mode should support "apos.on" for the "ready" event because everyone stubs their toe on it

“apos.on” does not exist in lean mode. That makes sense. However everybody gets confused about how to attach their “enhance” or “ready” event handlers for non-widget code.

The right way to do that is:

if (!apos.on) {
  // safely after DOM is ready, like $(function() { ... })
  apos.utils.ready(invokeMyThing);
} else {
  // safely after DOM is ready AND when new widgets are ajaxed into the page while editing
  apos.on('enhance', invokeMyThing);
}

But this pattern is really tedious and everyone is having a tough time with it, which is breaking code on the front end.

So I propose it is worth a few bytes to support apos.on in the lean library, and to just have ready and enhance fire at apos.utils.ready time in lean mode, so code works either way. A few of the “if” statements above and you’ll actually have more code bloat than this simple pokeyoke to prevent bugs.

[boutell]

My concern isn’t tedium, it’s the bug-prone nature of saying “you have to write this if statement to deal with the two cases, and you have to write it in many places.” That’s a clear tell that we should provide a simple way to work in both situations.

[stuartromanek]

If lean mode had more definition around it would be easier to make these decisions.

If lean mode just means no external dependencies then I don’t feel bad about filling in normal front-end apos functionality to keep code consistent and One Way.

The documentation for lean should be beefed up by adding a section around running non-widget code. Lean mode might also benefit from not just throwing everything into apos.utils, where we’re currently mixing jquery-like helpers with apostrophe specific ready code.