Add Attempt count to PolicyResult [general: expand info on Policy execution available in PolicyResult]

We are using ExecuteAndCapture in our application, the policy is defined in configuration but executed elsewhere. I’d like to log whether a retry has happened (and how many) but all I have is PolicyResult to work from.

In one part of the app, we define a function which builds a policy:

config.BuildExceptionPolicy(() => Policy.Handle<IOxception>().RetryAsync(2));

And execute it in another:

var policy = step.BuildExceptionPolicy();
return policy.ExecuteAndCaptureAsync(async () => { ... } );

If the outcome is Failure, I log the final exception but along side that I’d like to log the number of attempts that were taken.

[reisenberger]

Hi @TrevorPilley.

Because of the way the Polly execute methods are generalised, capturing the number of attempts into the PolicyResult is not that straightforward. .ExecuteAndCaptureAsync(...) is agnostic to (and has no knowledge of) whether what is being run underneath is a retry policy, circuit-breaker policy without retries (or indeed some new kind of action-transforming policy in the future).

An approach in the meantime could be something like :

int attempts = 0;
var policy = step.BuildExceptionPolicy();
var result = policy.ExecuteAndCaptureAsync(async () => { 
   attempts++;
   //  ... 
} );

@joelhulen : I suggest we leave this issue open for a while so that others can comment if they would also like additional execution metadata inPolicyResult.

[rvvincelli]

I think the proper way to do this now is with a context.