TypeScript Compiler Failing

🐛 Bug report

Failing to compile

Current behavior

I’m working in a monorepo. I installed reakit in a workspace and so the module gets hoisted to the top level node_modules and when I run tsc it fails and I get the following output (I did not include the whole thing, but all the errors are similar and they all occur in the reakit ts directory)

Usage:

import {
  usePopoverState,
  Popover,
  PopoverDisclosure,
  PopoverArrow,
} from 'reakit/Popover'

../../node_modules/reakit/ts/Tooltip/Tooltip.d.ts:19:1 - error TS1128: Declaration or statement expected.

19 };
   ~

../../node_modules/reakit/ts/Tooltip/TooltipArrow.d.ts:8:22 - error TS1005: ';' expected.

8     __keys: readonly any[];
                       ~~~

../../node_modules/reakit/ts/Tooltip/TooltipArrow.d.ts:8:25 - error TS1005: ',' expected.

8     __keys: readonly any[];
                          ~

../../node_modules/reakit/ts/Tooltip/TooltipArrow.d.ts:9:21 - error TS1109: Expression expected.

9     __propsAreEqual?: ((prev: import("..").BoxOptions & Pick<Partial<import("./TooltipState").TooltipStateReturn>, "unstable_arrowRef" | "unstable_arrowStyles"> & Pick<import("./TooltipState").TooltipStateReturn, "placement"> & import("react").HTMLAttributes<any> & import("react").RefAttributes<any> & {
                      ~

../../node_modules/reakit/ts/Tooltip/TooltipArrow.d.ts:14:1 - error TS1128: Declaration or statement expected.

14 };
   ~

../../node_modules/reakit/ts/Tooltip/TooltipReference.d.ts:9:22 - error TS1005: ';' expected.

9     __keys: readonly any[];
                       ~~~

../../node_modules/reakit/ts/Tooltip/TooltipReference.d.ts:9:25 - error TS1005: ',' expected.

9     __keys: readonly any[];
                          ~

../../node_modules/reakit/ts/Tooltip/TooltipReference.d.ts:10:21 - error TS1109: Expression expected.

10     __propsAreEqual?: ((prev: BoxOptions & Pick<Partial<TooltipStateReturn>, "unstable_referenceRef" | "unstable_hiddenId"> & Pick<TooltipStateReturn, "hide" | "show"> & import("react").HTMLAttributes<any> & import("react").RefAttributes<any> & {
                       ~

../../node_modules/reakit/ts/Tooltip/TooltipReference.d.ts:15:1 - error TS1128: Declaration or statement expected.

15 };
   ~

../../node_modules/reakit/ts/VisuallyHidden/VisuallyHidden.d.ts:8:22 - error TS1005: ';' expected.

8     __keys: readonly any[];
                       ~~~

../../node_modules/reakit/ts/VisuallyHidden/VisuallyHidden.d.ts:8:25 - error TS1005: ',' expected.

8     __keys: readonly any[];
                          ~

../../node_modules/reakit/ts/VisuallyHidden/VisuallyHidden.d.ts:9:21 - error TS1109: Expression expected.

9     __propsAreEqual?: ((prev: BoxOptions & import("react").HTMLAttributes<any> & import("react").RefAttributes<any> & {
                      ~

../../node_modules/reakit/ts/VisuallyHidden/VisuallyHidden.d.ts:14:1 - error TS1128: Declaration or statement expected.

14 };

Steps to reproduce the bug

Provide a repo or sandbox with the bug and describe the steps to reproduce it.

1. Open sandbox: https://codesandbox.io/s/m4n32vjkoj (you can use it as a base)
2. Remove any line
3. See console logs

Expected behavior

It should compile without any errors.

Possible solutions

If possible, describe how this bug could be fixed.

Environment

root tsconfig.json looks like this:

{
  "compilerOptions": {
    "forceConsistentCasingInFileNames": true,
    "experimentalDecorators": true,
    "sourceMap": true,
    "strict": true,
    "strictNullChecks": true,
    "noImplicitAny": true,
    "noUnusedLocals": false,
    "module": "esnext",
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es5",
    "jsx": "react",
    "declaration": true,
    "lib": ["es7", "dom", "esnext"],
    "typeRoots": ["../../node_modules/@types"],
    "types": [
      "express",
      "jest",
      "node",
      "numeral",
      "react",
      "react-dom",
      "react-router",
      "react-table"
    ]
  }
}

package tsconfig:

{
  "extends": "../config/tsconfig.json",
  "compilerOptions": {
    "outDir": "dist",
    "rootDir": "src",
    "declaration": true
  },
  "include": ["src/**/*"],
  "exclude": ["node_modules/**"]
}

System:
    OS: macOS 10.14
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 298.29 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.9.0 - ~/.nvm/versions/node/v10.9.0/bin/node
    Yarn: 1.15.0 - ~/.nvm/versions/node/v10.9.0/bin/yarn
    npm: 6.2.0 - ~/.nvm/versions/node/v10.9.0/bin/npm

[prwelber]

I think we changed the import path to ‘reakit/es/<component>’

On Fri, Jun 14, 2019 at 8:51 PM Craig Cavalier [e-mail] wrote:

@prwelber https://github.com/prwelber can you share how your coworker figured this out? I’m bumping into the same set of errors.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/reakit/reakit/issues/367?email_source=notifications&email_token=ADBIVZ7C7HQQTJZEJ776Z2TP2Q4KLA5CNFSM4HQGYCCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYM3OI#issuecomment-502320569, or mute the thread https://github.com/notifications/unsubscribe-auth/ADBIVZYKZ6MUN4H6DPUSJYTP2Q4KLANCNFSM4HQGYCCA .

– Sent from Gmail Mobile

[CraigCav]

@diegohaz Yup, that did the trick. Thank you so much for figuring this out.