[2.6][T4] Discussion: Set 'Version: 2' as default or make it easier to configureSee original GitHub issue
When creating a transaction with the TransactionBuilder and signing it with the ‘regular’
.sign() function, set
Version to 2 by default. Alternatively, make it easier to mutate the value, other than modifying the
Version: 2transactions will be the new standard as
Version: 1are is going to be deprecated in the future. Therefore, the SDK user should not have to put in extra effort to create a transaction that is now the default.
Simplicity. The SDK should be easy to use and having to set
Managers.configManager.setHeight(4006000);(devnet) does not fit this picture.
.builder() function support
Version: 2 transactions. With the
TransactionBuilder it is currently already possible to set the Version with the
.version() function, however an error is returned while trying to build the transaction with the
UnhandledPromiseRejectionWarning: TransactionVersionError: Version 2 not supported.
Your Environment @arkecosystem/crypto: 2.6.0-next.2
- Created 4 years ago
- Comments:13 (4 by maintainers)
Top GitHub Comments
We could default the package to require v2 transactions but this would be a breaking change which could affect all forks and bridgechains and things like wallets so this needs to be done with a long enough heads up for those to adjust.
The desktop wallet for example would need to switch between v1 and v2 transactions depending on the network as some networks might lag behind with applying the 2.6 update.
I’ll bring this up internally as it makes sense for ARK itself to default to 2.0 and think about how to best approach this without breaking potentially affected applications and bridgechains.
This issue has been closed. If you wish to re-open it please provide additional information.