core-transaction-pool: dynamicfee-matcher.js

https://github.com/ArkEcosystem/core/blob/develop/packages/core-transaction-pool/lib/utils/dynamicfee-matcher.js

I don’t like the logic in this file. Imo it should be if(feeConstants.dynamic) === true and else static. Also inside dynamic the static fees should be completely ignored: https://github.com/ArkEcosystem/core/blob/a07be2a12a9a73847fc453fa1c7732b9efd0bbdc/packages/core-transaction-pool/lib/utils/dynamicfee-matcher.js#L35-L38 What if my dynamic fee is higher than the static? This check will reject all trxs.

To prevent trxs with a very high fee, how about to add config.delegates.dynamicFees.maxAcceptableFee?

[faustbrian]

I think the maxAcceptableFee property isn’t a core issue but rather a UI/End-User issue. UI/End-User integrations should take care of making sure the user selects the right fees and warn the user that he is about to select a fee that exceeds the static fees.

If someone wishes to pay 100 ARK as a fee for a transaction that is their decision, core should only care about validating and processing the transaction. If it has a 100 ARK fee and is valid the transaction is good to go.

[zillionn]

Oh, and your PR https://github.com/ArkEcosystem/core/pull/1353 doesn’t solve my first issue. You’re still using config.delegates.dynamicFees.minAcceptableFee which I believe is only for the forger/delegate, if I’m running only a relay, I don’t use that setting.