Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

core-transaction-pool: dynamicfee-matcher.js

See original GitHub issue

I don’t like the logic in this file. Imo it should be if(feeConstants.dynamic) === true and else static. Also inside dynamic the static fees should be completely ignored: What if my dynamic fee is higher than the static? This check will reject all trxs.

To prevent trxs with a very high fee, how about to add config.delegates.dynamicFees.maxAcceptableFee?

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

faustbriancommented, Nov 10, 2018

I think the maxAcceptableFee property isn’t a core issue but rather a UI/End-User issue. UI/End-User integrations should take care of making sure the user selects the right fees and warn the user that he is about to select a fee that exceeds the static fees.

If someone wishes to pay 100 ARK as a fee for a transaction that is their decision, core should only care about validating and processing the transaction. If it has a 100 ARK fee and is valid the transaction is good to go.

zillionncommented, Nov 9, 2018

Oh, and your PR doesn’t solve my first issue. You’re still using config.delegates.dynamicFees.minAcceptableFee which I believe is only for the forger/delegate, if I’m running only a relay, I don’t use that setting.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found