discriminators performance

Hello,

Im using this kind of mapper :

this.mapper = JdbcMapperFactory
                        .newInstance()
                        .addKeys("id")
                        .discriminator(A.class,
                                "type",
                                ResultSet::getString,
                                builder-> builder.discriminatorCase("TYPEA1", A1.class)
                                builder-> builder.discriminatorCase("TYPEA2", A2.class)
                                builder-> builder.discriminatorCase("TYPEA3", A3.class)
                                builder-> builder.discriminatorCase("TYPEA4", A4.class)
                                .......
                        )
                        .discriminator(B.class,
                                "b_type",
                                ResultSet::getString,
                                builder-> builder.discriminatorCase("TYPEB1", B1.class)
                                builder-> builder.discriminatorCase("TYPEB2", B2.class)
                                builder-> builder.discriminatorCase("TYPEB3", B3.class)
                                builder-> builder.discriminatorCase("TYPEB4", B4.class)
                                ........
                        )
                .newMapper(A.class);

I have a resultset which contains 100K row with 7 columns.

Here is the code mapping rs to list :

		String query = "....";
		L.info("execute : {}", query);
		long start = System.currentTimeMillis();
		List objects = new ArrayList();
		try (PreparedStatement ps = this.datasource.getConnection().prepareStatement(query);
				ResultSet rs = ps.executeQuery()) {
			L.info("execute in {} ms", System.currentTimeMillis() - start);
			start = System.currentTimeMillis();
			objects = mapper.stream(rs).collect(Collectors.toList());
			L.info("mapped in {} ms", System.currentTimeMillis() - start);
		} catch (SQLException e) {
			L.error("impossible to map the result set", e);
		}

my timings are : execute in 288 ms mapped in 5103 ms

How can I help you troubleshoot this ?

[arnaudroger]

yep looks like it, I should be able to fix that.

Benchmark                                             Mode  Cnt      Score     Error  Units
DiscriminatorBenchmark.testNoDiscriminator            avgt    5     48.025 ±   5.033  ms/op
DiscriminatorBenchmark.testWithDiscriminator          avgt    5     93.178 ±   4.201  ms/op
DiscriminatorBenchmark.testWithDiscriminatorWithKeys  avgt    5  10041.184 ± 841.473  ms/op

[n1b0r]

thanks a lot for your support !