Negative timestamp parsing on windows: timestamp out of range for platform localtime()/gmtime() function

Thanks for arrow!

Over on conda-forge, our build of 0.15.1 turned up this test fail on windows:

ERROR: test_parse_timestamp (tests.parser_tests.DateTimeParserParseTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\bld\arrow_1568153654810\_test_env\lib\site-packages\chai\chai.py", line 63, in wrapper
    func(self, *args, **kwargs)
  File "D:\bld\arrow_1568153654810\test_tmp\tests\parser_tests.py", line 229, in test_parse_timestamp
    self.expected = datetime.fromtimestamp(negative_int_timestamp, tz=tz_utc)
ValueError: timestamp out of range for platform localtime()/gmtime() function

----------------------------------------------------------------------
Ran 385 tests in 1.109s

Excluding this on windows got things going again, but is this a cause for concern?

[bollwyvl]

Thanks for the clarification! Merged -1 minutes from now!

On Tue, Sep 10, 2019 at 9:47 PM Jad Chaar [e-mail] wrote:

@bollwyvl https://github.com/bollwyvl thanks for reporting this. This is due to the new regression tests we added as part of the fix for #662 https://github.com/crsmithdev/arrow/issues/662. It seems that datetime on Windows does not play nicely with negative timestamps (ref: https://stackoverflow.com/questions/36179914).

I will need to do some more investigating, but this should not be an issue if you are not using negative time stamps 😃.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/crsmithdev/arrow/issues/668?email_source=notifications&email_token=AAALCRADHDDS7MYQE35GOA3QJBE3ZA5CNFSM4IVNUWQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6M7UKI#issuecomment-530184745, or mute the thread https://github.com/notifications/unsubscribe-auth/AAALCRHNHBYQSSOCOWMHWN3QJBE3ZANCNFSM4IVNUWQA .

[jadchaar]

Hey @bollwyvl, we have released 0.15.2, which includes the fix for tests on Windows 😃.