Key property excluded from SQL

When you have an entity with a Guid key, that is not set to get its value from the DB, Upsert still excludes it because EF sets the ValueGenerated property to OnAdd, so the following line:

if (prop.ValueGenerated != ValueGenerated.Never) continue;

excludes the key and I get a SQL error saying the key column doesn’t accept nulls. The key is configured as such:

class Entity
{
	public Guid Id { get; set; }
	public string Name { get; set; }
}

class MyContext : DbContext
{
	protected override void OnModelCreating(ModelBuilder modelBuilder)
	{
		modelBuilder
			.Entity<Entity>()
			.HasKey(x => x.Id);
	}
}

No idea why EF specifies it this way, but the model works when inserting with EF normally (i.e. uses the value on the entity, rather than generating it on the DB)

[artiomchi]

Yup, absolutely! I’ll add it in the next release!

[corstian]

I think it’s clear now and we can close it. Maybe it’d be nice to add an exception in the future that’s a bit more clear on what’s going on 😉