question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

No coverage changes even though base branch & head branch has different code coverage

See original GitHub issue

Describe a bug

I comment some unit-test code on head branch, then make a pull request to base branch. The coverage action has been triggered as expected, and coverage comment has been made.

But, there is no coverage changes in action comment, see below plz. image

Expected behavior

Shows coverage changes correctly~

Details

  • Action version: v2.0

  • OS, where your action is running (windows, linux):

  • action.yml file
    ```yml
    cov-designer:
      runs-on: ubuntu-latest
      # skip fork's PR, otherwise it fails while making a comment
      if: ${{ github.event.pull_request.head.repo.full_name == 'alibaba/lowcode-engine' }}
      steps:
        - name: checkout
          uses: actions/checkout@v2
    
        - uses: actions/setup-node@v2
          with:
            node-version: '14'
    
        - name: install
          run: npm i && npm run setup:skip-build
    
        - uses: ArtiomTr/jest-coverage-report-action@v2
          with:
            working-directory: packages/designer
            test-script: npm test -- --jest-ci --jest-json --jest-coverage --jest-testLocationInResults --jest-outputFile=report.json
            package-manager: yarn
            annotations: none
    ```
    
  • Screenshots
    <!-- If you encounter an incorrect coverage comment display, replace this comment with screenshot -->
    
    <!-- If your action unexpectedly fails, please replace this comment with a screenshot of your console  -->
    

Additional context

Here is my test PR.

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:4
  • Comments:7 (2 by maintainers)

github_iconTop GitHub Comments

4reactions
LeoYuancommented, Jun 17, 2022

Agreed, it’s a better idea to let code owner knows what’s happened so they can make a decision to accept / reject PR. In this case, 1% is a ‘big’ number.😃

3reactions
ArtiomTrcommented, Sep 25, 2022

Fixed this, fix is available under the v2.1.1 tag or just v2

Read more comments on GitHub >

github_iconTop Results From Across the Web

Patch Status should compare to merge-base instead of HEAD
The base commit used for comparison would only change if the pull request is rebased, not upon new commits to the base branch....
Read more >
Lines to cover on new code is 0 in PR and for branches
Hi,. I just read this thread pull-request-branches-to-include-code-coverage and was excited. We have a policy of 100% code coverage on new code.
Read more >
Sudden significant coverage drop - Bug Fixes - Codecov
Recently the coverage has significantly dropped on my repo (cpp code), even though the last changes we've merged was related to docs (which ......
Read more >
Codecov : No coverage report created on git merge operation
Problem is Codecov merges all reports for a specific branch, not taking the branch into perpsective. This means our "master" branch will always ......
Read more >
Changes in the Feature Branch Are Not Merged in the ...
In summary: Only the additions or deletions in the feature branches are merged into the promotion unless there is a conflict during the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found