Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Some images not showing up (due to zero height)

See original GitHub issue

Reported on Slack: https://artsy.slack.com/archives/partner-s-help/p1487119184004472

Some images in this partner show are not being rendered in the artwork grid layout:

nan

It appears that there is a ViewHelper which tries to calculate some optimal layout settings based on an image’s width and height as returned by Metaphysics

BUT… sometimes Metaphysics doesn’t return the height/width metadata for an image, as shown by these console.logs (note the nulls)… which results in a div by zero / NaN value being passed to the template.

2:23:18 PM web.1 |  { url: 'https://d32dm0rphc51dk.cloudfront.net/DwdY0-ehhWXGL-9-yTospw/large.jpg',
2:23:18 PM web.1 |    width: 3960,
2:23:18 PM web.1 |    height: 5026 }
2:23:18 PM web.1 |  { url: 'https://d32dm0rphc51dk.cloudfront.net/ysM4y7vfaPDBzQpitRJR0Q/large.jpg',
2:23:18 PM web.1 |    width: null,
2:23:18 PM web.1 |    height: null }
2:23:18 PM web.1 |  { url: 'https://d32dm0rphc51dk.cloudfront.net/cG-FFMpEWY9wbnH5cE7BvA/large.jpg',
2:23:18 PM web.1 |    width: null,
2:23:18 PM web.1 |    height: null }
2:23:18 PM web.1 |  { url: 'https://d32dm0rphc51dk.cloudfront.net/J_NOHi4zf-_4jxyd1zVzGw/large.jpg',
2:23:18 PM web.1 |    width: 900,
2:23:18 PM web.1 |    height: 428 }