Make count fields plain integers.

TL;DR

In short, I would like us to use a plain GraphQLInt for counts fields. I don’t really see a need to be able to format a count in MP, but would like to know if others have objections.

---

As we move to TypeScript and convert MP’s schema to type declarations, we’re running into the issue that for many (all?) of the counts fields we have, the resulting type declaration is number | string | boolean, because we are using a custom scalar rather than a specific subtype.

This type declaration is problematic because it would require us to go through hoops to cast the value as a number in order to safely write code like:

const not_for_sale_works = artist.counts.artworks - artist.counts.for_sale_works

The TypeScript compiler will fail with the following error:

error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number' or an enum type.
error TS2363: The right-hand side of an arithmetic operation must be of type 'any', 'number' or an enum type.

/cc @sweir27 @broskoski @l2succes

[broskoski]

@alloy Not automatically. pageInfo only returns cursors (startCursor and endCursor) as well as whether there are more page results or not. See: https://facebook.github.io/relay/graphql/connections.htm#sec-undefined.PageInfo

[alloy]

@broskoski Good point, we can just prefix the int fields. Maybe as another nested field? E.g.

counts {
  raw {
    for_sale_artworks
  }
}

Not a big fan of the word ‘raw’, though.