OkHttp 4

Square recently released OkHttp 4. It’s a Kotlin porting of OkHttp 3 with some minor changes and will be the basis of all the subsequent Square releases, so it’s important to upgrade gander, as it currently crashes when used in an app with OkHttp 4. I can help with a PR but I preferred to write here first to let you know and have your feedback about it.

This is the stack trace:

java.lang.NoSuchMethodError: No static method hasBody(Lokhttp3/Response;)Z in class Lokhttp3/internal/http/HttpHeaders; or its super classes
        at com.ashokvarma.gander.GanderInterceptor.updateTransactionFromResponse(GanderInterceptor.java:250)
        at com.ashokvarma.gander.GanderInterceptor.intercept(GanderInterceptor.java:161)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:112)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:87)

And this is the official thread: https://github.com/square/okhttp/issues/5246 in which square devs advises to not rely on that method, but to copy and paste this one: https://github.com/square/okhttp/blob/eee838aebe8d3524d7e0e2dbf8f9bf357512f038/okhttp/src/main/java/okhttp3/internal/http/HttpHeaders.kt#L213

[gotev]

@Ashok-Varma made a check and it appears it was the only OkHttp internal method used 😉

Just as advice, to ease other developers contributions consider adding CONTRIBUTING.md and CODE_OF_CONDUCT.md to your repo. This can be useful as an example: https://gist.github.com/PurpleBooth/b24679402957c63ec426

[gotev]

Fantastic!!