regression in node 8

added node 8 to node-mysql2 build and one of cesu8 tests fails now. Simple example to reproduce:

node 0.10.48 ( any pre 8.x )

> var iconv = require('iconv-lite')
> iconv.decode(Buffer('eda0bdedb2a9', 'hex'), 'cesu8')
'💩'
> Buffer(iconv.decode(Buffer('eda0bdedb2a9', 'hex'), 'cesu8'))
<Buffer f0 9f 92 a9>

node 8.1.0:

> var iconv = require('iconv-lite')
undefined
> iconv.decode(Buffer('eda0bdedb2a9', 'hex'), 'cesu8')
'��'
> Buffer.from(iconv.decode(Buffer.from('eda0bdedb2a9', 'hex'), 'cesu8'))
<Buffer ef bf bd ef bf bd>

[sidorares]

@chalker I had 3 bug reports next day after I accidentally released node-mysql2 with one of the functions using new API without shim, there are still plenty of pre node 4.5 users

[ashtuchkin]

Thanks for the report! I reproduced it and will fix soon.

I’ll need to replace the check here: https://github.com/ashtuchkin/iconv-lite/blob/master/encodings/internal.js#L38 to something like new Buffer('eda0bdedb2a9', 'hex').toString() !== '💩'