"Unparsable" NotImplemementedError when getting values from variables

If setup.py gets setup() values from variables, the script blows up with a NotImplementedError:

Traceback (most recent call last):
  File "site-packages/setup_py_upgrade.py", line 125, in visit_Call
    value = ast.literal_eval(kwd.value)
  File "ast.py", line 85, in literal_eval
    return _convert(node_or_string)
  File "ast.py", line 84, in _convert
    raise ValueError('malformed node or string: ' + repr(node))
ValueError: malformed node or string: <_ast.Name object at 0x7fdf99964e10>

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "setup-py-upgrade", line 8, in <module>
    sys.exit(main())
  File "site-packages/setup_py_upgrade.py", line 167, in main
    visitor.visit(tree)
  File "ast.py", line 253, in visit
    return visitor(node)
  File "ast.py", line 261, in generic_visit
    self.visit(item)
  File "ast.py", line 253, in visit
    return visitor(node)
  File "ast.py", line 263, in generic_visit
    self.visit(value)
  File "ast.py", line 253, in visit
    return visitor(node)
  File "setup_py_upgrade.py", line 127, in visit_Call
    raise NotImplementedError(f'unparsable: {kwd.arg}=')
NotImplementedError: unparsable: version=

This probably isn’t fully fixable as the variable could be a constant, or it might come from a separate python file, or even from reading some data from an external file.

[asottile]

note that in the general case you’re asking setup-py-upgrade to solve the halting problem, which is intractable

[asottile]

there’s no reason to write a setup py like that, inline it and it’ll get converted – see above