Proposal: Migrate instrumentation-aws-sdk to opentelemetry-js-contrib
See original GitHub issueFirst off, I want to thank the maintainers of this repo for their hard work and fantastic contributions to the instrumentations in this repo and the OpenTelemetry project at large. I am from the AWS X-Ray team, and we have really enjoyed using many of the instrumentations here, particularly the AWS SDK one. We even officially recommend it for for AWS customers using OTel.
However as we bring our OpenTelemetry distro out of public preview and into GA, we are not able to rely on a third-party hosted package for AWS SDK instrumentation. We would like to offer assistance in maintaining it, and also hopefully exposure to an even larger customer base, while also allowing the Aspecto team to continue to have ownership of it. That is why we are proposing that the opentelemetry-instrumentation-aws-sdk
be moved upstream to the opentelemetry-js-contrib
repo. All current Aspecto maintainers would continue to be CODEOWNERS (or whatever equivalent we come up with for package ownership in contrib) in addition to some engineers from AWS.
As discussed in #93, I believe @blumamir is now an approver in contrib, and I would hope we could discuss adding another approver from this repo so you’d be able to continue to iterate quickly in contrib as well. Being in contrib and having the @opentelemetry
namespace would also hopefully lend well-deserved discoverability and credibility to the project. I will leave it up to the maintainers to decide where the other instrumentations in this repo should reside, but as the only one tied to a vendor the AWS SDK one seems like the odd one out.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:7
- Comments:9 (5 by maintainers)
Top GitHub Comments
Yesterday at the SIG meeting we discussed the issues above. Will start migrating the package to contrib in the following days.
OTel JS will be moving to independent releases for packages by using https://github.com/googleapis/release-please. We are also going to try to assign ownership of packages in the contrib repo which will allow those package owners to merge changes more quickly. We hope this combination of changes will alleviate concerns with respect to merge and release velocity.