question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Proposal: Migrate instrumentation-aws-sdk to opentelemetry-js-contrib

See original GitHub issue

First off, I want to thank the maintainers of this repo for their hard work and fantastic contributions to the instrumentations in this repo and the OpenTelemetry project at large. I am from the AWS X-Ray team, and we have really enjoyed using many of the instrumentations here, particularly the AWS SDK one. We even officially recommend it for for AWS customers using OTel.

However as we bring our OpenTelemetry distro out of public preview and into GA, we are not able to rely on a third-party hosted package for AWS SDK instrumentation. We would like to offer assistance in maintaining it, and also hopefully exposure to an even larger customer base, while also allowing the Aspecto team to continue to have ownership of it. That is why we are proposing that the opentelemetry-instrumentation-aws-sdk be moved upstream to the opentelemetry-js-contrib repo. All current Aspecto maintainers would continue to be CODEOWNERS (or whatever equivalent we come up with for package ownership in contrib) in addition to some engineers from AWS.

As discussed in #93, I believe @blumamir is now an approver in contrib, and I would hope we could discuss adding another approver from this repo so you’d be able to continue to iterate quickly in contrib as well. Being in contrib and having the @opentelemetry namespace would also hopefully lend well-deserved discoverability and credibility to the project. I will leave it up to the maintainers to decide where the other instrumentations in this repo should reside, but as the only one tied to a vendor the AWS SDK one seems like the odd one out.

/cc @alolita @NathanielRN @anuraaga @dyladan

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:7
  • Comments:9 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
blumamircommented, Aug 12, 2021

Yesterday at the SIG meeting we discussed the issues above. Will start migrating the package to contrib in the following days.

3reactions
dyladancommented, Aug 6, 2021

OTel JS will be moving to independent releases for packages by using https://github.com/googleapis/release-please. We are also going to try to assign ownership of packages in the contrib repo which will allow those package owners to merge changes more quickly. We hope this combination of changes will alleviate concerns with respect to merge and release velocity.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add AWS SDK Instrumentation · Issue #323
I would like there to be an instrumentation package for the AWS SDK, so that requests made with AWS SDK V2 (and the...
Read more >
OpenTelemetry aws-sdk Instrumentation for Node.js
This module provides automatic instrumentation for the aws-sdk v2 and @aws-sdk v3 modules, which may be loaded using the @opentelemetry/sdk- ...
Read more >
Using instrumentation libraries
You can use instrumentation libraries in order to generate telemetry data for a library or framework. For example, the instrumentation library ...
Read more >
AWS Distro for OpenTelemetry FAQs
In order to migrate to AWS Distro for OpenTelemetry, you can use the auto-instrumentation agent for Java or instrument your application using OpenTelemetry...
Read more >
Tracing with the AWS Distro for OpenTelemetry JavaScript ...
This guide will go over how to configure the relevant components of the ADOT SDK to send trace data to the AWS X-Ray...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found