EntityHistory doesn't support Owned Entity with Multiple FKs

Abp version: 5.1.0 (tested on up-to-date dev branch) Target framework: NET Core 3.1 Stack trace:

System.NullReferenceException : Object reference not set to an instance of an object.
   at Abp.EntityHistory.EntityHistoryHelper.CreateEntityChangeSet(ICollection`1 entityEntries) in D:\git\aspnetboilerplate\src\Abp.ZeroCore.EntityFrameworkCore\EntityHistory\EntityHistoryHelper.cs:line 83
   at Abp.Zero.EntityFrameworkCore.AbpZeroCommonDbContext`3.SaveChanges() in D:\git\aspnetboilerplate\src\Abp.ZeroCore.EntityFrameworkCore\Zero\EntityFrameworkCore\AbpZeroCommonDbContext.cs:line 157
   at Abp.EntityFrameworkCore.Repositories.EfCoreRepositoryBase`3.InsertAndGetId(TEntity entity) in D:\git\aspnetboilerplate\src\Abp.EntityFrameworkCore\EntityFrameworkCore\Repositories\EfCoreRepositoryBaseOfTEntityAndTPrimaryKey.cs:line 168
   at Castle.Proxies.Invocations.IRepository`2_InsertAndGetId_12.InvokeMethodOnTarget()
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at Abp.Domain.Uow.UnitOfWorkInterceptor.PerformSyncUow(IInvocation invocation, UnitOfWorkOptions options) in D:\git\aspnetboilerplate\src\Abp\Domain\Uow\UnitOfWorkInterceptor.cs:line 67
   at Abp.Domain.Uow.UnitOfWorkInterceptor.PerformUow(IInvocation invocation, UnitOfWorkOptions options) in D:\git\aspnetboilerplate\src\Abp\Domain\Uow\UnitOfWorkInterceptor.cs:line 59
   at Abp.Domain.Uow.UnitOfWorkInterceptor.Intercept(IInvocation invocation) in D:\git\aspnetboilerplate\src\Abp\Domain\Uow\UnitOfWorkInterceptor.cs:line 48
   at Castle.DynamicProxy.AbstractInvocation.Proceed()
   at Castle.Proxies.IRepository`1Proxy_6.InsertAndGetId(Foo entity)
   at Abp.Zero.EntityHistory.SimpleEntityHistory_Test.<>c__DisplayClass8_0.<Should_Write_History_For_Owned_Entities>b__0() in D:\git\aspnetboilerplate\test\Abp.ZeroCore.Tests\Zero\EntityHistory\SimpleEntityHistory_Test.cs:line 72
   at Abp.TestBase.AbpIntegratedTestBase`1.WithUnitOfWork(Action action, UnitOfWorkOptions options) in D:\git\aspnetboilerplate\src\Abp.TestBase\TestBase\AbpIntegratedTestBase.cs:line 154
   at Abp.Zero.EntityHistory.SimpleEntityHistory_Test.Should_Write_History_For_Owned_Entities() in D:\git\aspnetboilerplate\test\Abp.ZeroCore.Tests\Zero\EntityHistory\SimpleEntityHistory_Test.cs:line 62

Test classes:

    [Audited]
    public class Foo : Entity
    {
        public Bar Bar { get; set; }
    }

    [Owned]
    public class Bar
    {
        public int FooId { get; set; }

        public int? AnotherFooId { get; set; }
    }

DbContext configuration:

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            base.OnModelCreating(modelBuilder);

            modelBuilder.ConfigurePersistedGrantEntity();

            modelBuilder.Entity<Foo>(b =>
            {
                b.OwnsOne(f => f.Bar, a =>
                {
                    a.WithOwner().HasForeignKey(f => f.FooId);

                    a.HasOne<Foo>()
                        .WithOne()
                        .HasForeignKey<Bar>(bar => bar.AnotherFooId)
                        .IsRequired(false)
                        .OnDelete(DeleteBehavior.Cascade);
                });
            });
        }

Test case:

            WithUnitOfWork(() =>
            {
                var foo = new Foo
                {
                    Bar = new Bar()
                };
                _fooRepository.InsertAndGetId(foo);
            });

Decorating Bar with DisableAuditedAttribute or removing FK configuration makes the test method run without exceptions: looks like that issue is related to auditing FKs of Owned type.

[ryancyq]

Thanks @maliming, I will take over this issue and read about ef core documentation to see if we should implement a fix for this

[maliming]

According to the configuration of 4nonym0us , foreignKey.PrincipalToDependent will be null. So I suggest that he modify the configuration code.

Do you think we should modify the code to be compatible with these cases?

https://github.com/aspnetboilerplate/aspnetboilerplate/blob/f3f376544fb5e43f104270d81692a3c1e0eddc2c/src/Abp.ZeroCore.EntityFrameworkCore/EntityHistory/EntityHistoryHelper.cs#L83