Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Facing Problem when embedding file

See original GitHub issue

Your Abp package version: 3.0.0.0
Your base framework: .Net Core.

EmbeddedResourceSet has bug if the embedded file has “-”

This is because of this segment of code:

private string ConvertToRelativePath(string resourceName) {
    resourceName = resourceName.Substring(ResourceNamespace.Length + 1);

    var pathParts = resourceName.Split('.');
    if (pathParts.Length <= 2)
    {
        return resourceName;
    }            
    var folder = pathParts.Take(pathParts.Length - 2).Select(NormalizeFolderName).JoinAsString("/");
    var fileName = pathParts[pathParts.Length - 2] + "." + pathParts[pathParts.Length - 1];

    return folder + "/" + fileName;
}

When pathParts.Length <= 2, the code did not normalize the string,

However, when retrieving fileinfo. EmbeddedResourceManager normalizes the string no matter when:

public EmbeddedResourceItem GetResource(string fullPath)
{
    return _resources.Value.GetOrDefault(EmbeddedResourcePathHelper.NormalizePath(fullPath));
}

To reproduce it: Embed a file with “-” located in the root level, then try to get file info of it using EmbeddedResourceFileProvider

Expected: Get file info successfully Actual: File Info not found

Furthermore, since:

public IDirectoryContents GetDirectoryContents(string subpath)
        {
            if (!IsInitialized())
            {
                return new NotFoundDirectoryContents();
            }

            //TODO: Implement...?

            return new NotFoundDirectoryContents();
        }

May I ask if there is a plan to implement this method?

Thank you.