question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Feature Request: Support multiple notification distributors

See original GitHub issue

Just building on this question: https://github.com/aspnetboilerplate/aspnetboilerplate/issues/2743

It would be nice if a developer could implement and register multiple implementations of INotificationDistributer so that one could support SMS, email, and real-time notifications. It could be designed such that each subscription could define which “channels” the user would like to receive notifications on, i.e. if a user wanted to get friend request notifications with SMS, he/she could subscribe to the FriendRequest notification on the SMS channel.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:5
  • Comments:7 (1 by maintainers)

github_iconTop GitHub Comments

2reactions
willsewardcommented, Aug 28, 2018

I tried a lot to format my code but couldn’t do it. Sorry for crappy formatting.

Use three ` characters to start the code.

0reactions
saurabhpaticommented, Sep 2, 2018

@danijel-peric @willseward , I really like the collection of IRealTimeNotifiers idea. I created channels basically as markers to persist the channel information into the AbpTenantNotifications Table to persist notifications with their respective channel. So, I used the Table per Hierarchy in EF Core to implement the same. One improvement that I could have done agreeing to you is that I could have used channels in this way.

_iocManager.IocContainer.ResolveAll<NotificationChannelBase>();

Advantages:

  • Removes the Channel-Notifier coupling that I had above.
  • Much better standardized DI resolution way than Reflection.

Thank you guyz for your suggestion.

Read more comments on GitHub >

github_iconTop Results From Across the Web

3 ways to manage feature requests
The best way to keep feature requests in one place is to set up a centralized repository. Whether a feature request is received...
Read more >
Feature Request: Additional e-mail recipients, time to send.
I have used a mail server with a powershell script to send notification to multiple recipients before version 1.50 hit. The point is...
Read more >
Feature Request
I would like to be able to distinguish between multiple storefronts on MSF, by setting two separate order starting numbers. At the moment...
Read more >
Add UnifiedPush support to Home-Assistant Android / Core
UnifiedPush allows multiple, different apps (like Home-Assistant) to use a single notification push server which a user can configure.
Read more >
Feature Requests with SkySwitch
This article explains how SkySwitch handles feature requests submitted by its resellers.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found