InsertAndGetId return wrong Id when we have byte as primary key.

When we have byte as primary key it return highest number that byte can hold as a primary key for the first time after that it decreases the number by 1.

so first time it returns 255, second time 244 and so on …

When I’m stopping the app and again running the app it again return id as 255 first time and decreases by one each time.

but in the database it does save the id starting from 1 ,2 ,3 , 4…

Entity

 public  class TestEntity :Entity<byte>
    {
    }

DbContext

  public virtual DbSet<TestEntity.TestEntity> TestEntities { get; set; }
        public TestProjectDbContext(DbContextOptions<TestProjectDbContext> options)
            : base(options)
        {
        }
        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            base.OnModelCreating(modelBuilder);

            modelBuilder
                .Entity<TestEntity.TestEntity>(
                     entity =>
                     {
                         entity.Property(e => e.Id).ValueGeneratedOnAdd();
                     });

        }

Application Service

  public class TestAppService : TestProjectAppServiceBase, ITestAppService
    {
        private readonly IRepository<TestEntity, byte> _repository;

        public TestAppService(IRepository<TestEntity,byte> repository)
        {
            _repository = repository;
        } 
        public async Task<byte> InsertorUpdateAndGetIdAsync(TestEntity entity)
        {
            var res =await  _repository.InsertAndGetIdAsync(entity);
            return res;
        }
    }

This is the issue with all the inserts that returns id (InsertAndGetIdAsync,InsertAndGetId , InsertOrUpdateAndGetId and InsertOrUpdateAndGetIdAsync)

• Abp package version : 4.1.0
• base framework: .Net Core.
• SQL server

[hikalkan]

Yes, this will help. When it sets to a value like 255, ABP thinks that it’s already saved and this is a real id value and does not call Context.SaveChangesAsync().

However, I suggest you to don’t use byte as PK. Microsoft’s implementation is not good. If you ever will have 255 different values, why do you care about the PK size, just use int 😃

[iAmBipinPaul]

Okay , will use int for Pk. Thank you 👍 !