ISoftDelete with EF Core for Oracle, ORA-00972: identifier is too long Error

• Your Abp package version. 3.7

• Your base framework: .Net Framework or .Net Core. Net Core 2.1

• Exception message and stack trace if available. Oracle has a 30 character restriction for all object names.

ISoftDelete translate to “ef_filter__IsSoftDeleteFilterEnabled_0”(length > 30) in DbCommand.

ERROR 2019-01-09 10:33:52,245 [1    ] Default                                  - Failed executing DbCommand (290ms) [Parameters=[:ef_filter__IsSoftDeleteFilterEnabled_0='?' (DbType = Int16)], CommandType='Text', CommandTimeout='0']
SELECT COUNT(*)
FROM "ssrptmplmst" "e"
WHERE ("e"."delete_flag" = 0) OR ("e"."delete_flag" <> :ef_filter__IsSoftDeleteFilterEnabled_0)
Oracle.ManagedDataAccess.Client.OracleException (0x80004005): ORA-00972: 标识符过长
   at OracleInternal.ServiceObjects.OracleConnectionImpl.VerifyExecution(Int32& cursorId, Boolean bThrowArrayBindRelatedErrors, SqlStatementType sqlStatementType, Int32 arrayBindCount, OracleException& exceptionForArrayBindDML, Boolean& hasMoreRowsInDB, Boolean bFirstIterationDone)
   at OracleInternal.ServiceObjects.OracleCommandImpl.ExecuteReader(String commandText, OracleParameterCollection paramColl, CommandType commandType, OracleConnectionImpl connectionImpl, OracleDataReaderImpl& rdrImpl, Int32 longFetchSize, Int64 clientInitialLOBFS, OracleDependencyImpl orclDependencyImpl, Int64[] scnForExecution, Int64[]& scnFromExecution, OracleParameterCollection& bindByPositionParamColl, Boolean& bBindParamPresent, Int64& internalInitialLOBFS, OracleException& exceptionForArrayBindDML, OracleConnection connection, OracleLogicalTransaction& oracleLogicalTransaction, IEnumerable`1 adrianParsedStmt, Boolean isDescribeOnly, Boolean isFromEF)
   at Oracle.ManagedDataAccess.Client.OracleCommand.ExecuteReader(Boolean requery, Boolean fillRequest, CommandBehavior behavior)
   at Oracle.ManagedDataAccess.Client.OracleCommand.ExecuteDbDataReader(CommandBehavior behavior)
   at Oracle.EntityFrameworkCore.Storage.Internal.OracleRelationalCommandBuilderFactory.OracleRelationalCommandBuilder.OracleRelationalCommand.Execute(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary`2 parameterValues)

Override CreateFilterExpression(AbpDbContext)

Expression<Func<TEntity, bool>> softDeleteFilter = e => !((ISoftDelete)e).IsDeleted || ((ISoftDelete)e).IsDeleted != IsSoftDeleteFilterEnabled;

modified to

var SDFE = IsSoftDeleteFilterEnabled;
Expression<Func<TEntity, bool>> softDeleteFilter = e => !((ISoftDelete)e).IsDeleted || ((ISoftDelete)e).IsDeleted != SDFE;

can avoid this error, but I don’t think it’s a good practice. IMayHaveTenant and IMustHaveTenant may also have the same problem.

• Steps needed to reproduce the problem. Use ISoftDelete feature for any entity with oracle database. The EF Core for Oracle is in private test, you can email [e-mail] for the package.

[acjh]

protected virtual bool SDFE => CurrentUnitOfWorkProvider?.Current?.IsFilterEnabled(AbpDataFilters.SoftDelete) == true;

This should be sufficient:

protected virtual bool SDFE => IsSoftDeleteFilterEnabled;

---

From https://github.com/aspnet/EntityFrameworkCore/pull/8283, Oracle should set this:

public override int MaxTableAliasLength => 30;

[maliming]

@NepPure @ismcagdas

I think shortening the parameter name in Abp is not a good solution.

@NepPure There is a problem with your previous solution. see https://github.com/aspnetboilerplate/aspnetboilerplate/pull/4195#issuecomment-455412984 You can customize the short parameters by referring to the Abp code, and then override the CreateFilterExpression method to resolve them with short parameters.

https://github.com/aspnetboilerplate/aspnetboilerplate/blob/dev/src/Abp.EntityFrameworkCore/EntityFrameworkCore/AbpDbContext.cs#L78

But in the end it should be solved by the EF Core or ORACLE database provider.