Optimize the method: Abp.Organizations.OrganizationUnitManager.ValidateOrganizationUnitAsync(OrganizationUnit organizationUnit)

old： ` protected virtual async Task ValidateOrganizationUnitAsync(OrganizationUnit organizationUnit) { var siblings = (await FindChildrenAsync(organizationUnit.ParentId)) .Where(ou => ou.Id != organizationUnit.Id) .ToList();

        if (siblings.Any(ou => ou.DisplayName == organizationUnit.DisplayName))
        {
            throw new UserFriendlyException(L("OrganizationUnitDuplicateDisplayNameWarning", organizationUnit.DisplayName));
        }
    }

`

new： ` protected virtual async Task ValidateOrganizationUnitAsync(OrganizationUnit organizationUnit) { var siblings = (await FindChildrenAsync(organizationUnit.ParentId)) .Where(ou => ou.Id != organizationUnit.Id && ou.DisplayName == organizationUnit.DisplayName).Any();

        if (siblings)
        {
            throw new UserFriendlyException(L("OrganizationUnitDuplicateDisplayNameWarning", organizationUnit.DisplayName));
        }
    }

`

[easyfast]

但，这个是同步方法啊。换用异步方法，不是更快吗？

[acjh]

For reference: OrganizationUnitManager.cs#L123-L133

---

the best: ...CountAsync(... && o.DisplayName != organizationUnit.DisplayName);

• Any is faster than CountAsync
• Chain .Where instead of && for clarity
• Be careful, it should remain as ==

My suggestion:

var hasSiblingWithDuplicateDisplayName = OrganizationUnitRepository
    .Where(ou => ou.ParentId == organizationUnit.ParentId)
    .Where(ou => ou.Id != organizationUnit.Id)
    .Where(ou => ou.DisplayName == organizationUnit.DisplayName)
    .Any();

if (hasSiblingWithDuplicateDisplayName)
{
    throw new UserFriendlyException(L("OrganizationUnitDuplicateDisplayNameWarning", organizationUnit.DisplayName));
}

Note: You can use ```c# for code blocks with syntax highlighting.