Sharing connections, EfCoreStrategy and multitenancy

Hi,

i read how i can share connection if i use multidbcontext in #1834 It works well in single database.

Is this multitenancy safe ? I mean, if i use tennant per database concept will code

options.DbContextOptions.UseSqlServer(options.ExistingConnection)

return existingconnection of current tennant ?

If so does it mean that options object is per tennant ?

[hikalkan]

It’s not cached. The method below is called every time when a new database connection is needed:

            Configuration.Modules.AbpEfCore().AddDbContext<MyDbContext>(options =>
            {
                if (options.ExistingConnection != null)
                {
                    options.DbContextOptions.UseSqlServer(options.ExistingConnection);
                }
                else
                {
                    options.DbContextOptions.UseSqlServer(options.ConnectionString);
                }
            });

This class is responsible to select correct connection string based on current tenant: https://github.com/aspnetboilerplate/module-zero/blob/dev/src/Abp.ZeroCore.EntityFrameworkCore/Zero/EntityFrameworkCore/DbPerTenantConnectionStringResolver.cs

In brief, it works as expected 😃

[ismcagdas]

thanks for the feedback @HossamZaki.