Field comparison not ignoring synthetic members

Thanks for a great library.

We are using JaCoCo for test coverage. This adds a private static field $jacocoData to classes under test, which is marked as synthetic (see My code uses reflection. Why does it fail when I execute it with JaCoCo? in http://eclemma.org/jacoco/trunk/doc/faq.html).

Assertj then fails the test when comparing classes field by field as the $jacocoData is different between the expected and actual. So

assertThat(eventClass).isEqualToIgnoringGivenFields(data, "types", "primaryMarkets");

then fails with the error:

java.lang.AssertionError: 
Expecting value <[true, false, true, true]> in field <"$jacocoData"> but was <[true, true, true, true, true, true, true, true]> in <EventClass@2ef1972f>.
Comparison was performed on all fields but <["types", "primaryMarkets"]>

I can work round it by adding $jacocoData to the ignored fields, but this would be fail if JaCoCo changed to use a different name or we switched to an alternative coverage tool. Ideally therefore instead assertj should ignore synthetic members as the JaCoCo FAQ suggests.

[PascalSchumacher]

@joel-costigliola I guess Field.isSynthetic() can be used?

[joel-costigliola]

Whatever goes in 2.4 will be in 3.4, for the release you will have to wait, I’m in holidays 😃 so probably in one month.