Soft assertion chain broken by asInstanceOf() and extracting()

Summary

The bytecode manipulation magic that makes soft assertions work doesn’t work with custom assertion factories, such as those used by extracting(), asInstanceOf(), etc.

I think this is related to #2495 and could be tackled at the same time.

Example

Object o = "string";

softly.assertThat(o)
    .asInstanceOf(InstanceOfAssertFactories.STRING)
    .contains("a")
    .endsWith("b");

The call to asInstanceOf() breaks the soft chain. So if the contains() assert fails, it will throw an AssertionFailedError, the rest of the test method won’t run (including endWith()), and any soft assertions collected won’t be reported.

Solution

asInstanceOf() and methods like it should:

1. Create the assertion using AssertionFactory.createAssert()
2. Check to see if this is a soft assertion (this can be done by introspection to look for the errorCollector field added by the SoftProxies).
   1. If it is not, return the created assertion as normal.
   2. If it is, then generated a soft proxied copy of the created assertion using this.errorCollector as the error collector and return this instead of the raw created assertion.

A protected method in AbstractAssert should encapsulate this functionality so that custom assertions can leverage it too (as much of the necessary machinery is tucked away in package-private fields).

[kriegfrj]

Sorry, this issue has been flushed from my cache 😄 - when I get back to this problem I’ll double-check.

[Bananeweizen]

I guess this is basically the same bug pattern?

softly.assertThat(somePath)
.content() // breaks on first path not existing instead of continuing the soft assertions
.contains("foo");