Can we had n_filters to BaseDCUNet ?

❓ BaseDCUNet and DCCRN:

In the BaseDCUNet class which is also used for DCCRNet we assume that n_filters=stft_kernel_size.

 def __init__(
        self,
        architecture,
        stft_kernel_size=512,
        stft_stride=None,
        sample_rate=16000.0,
        **masknet_kwargs,
    ):
        self.architecture = architecture
        self.stft_kernel_size = stft_kernel_size
        self.stft_stride = stft_stride
        self.masknet_kwargs = masknet_kwargs

        encoder, decoder = make_enc_dec(
            "stft",
            kernel_size=stft_kernel_size,
            n_filters=stft_kernel_size,
            stride=stft_stride,
            sample_rate=sample_rate,
        )

In the DCCRN paper it’s said

3.2. Training setup and baselines For all of the models, the window length and hop size are 25 msand 6.25 ms, and the FFT length is 512.

To match the paper design, can we add n_filters as an argument of BaseDCUNet ?

[mpariente]

Let’s start with adding stft_n_filters only because it’s backward compatible. We’ll see later about adding fb_name, because it has other implications (as said by @JorisCos)

[mpariente]

I realize now that we did neither 1 or 2. We broke backward compat with the arguments but restricted the STFT. I’ll close, because adding fb_name was not the purpose of this issue.