Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Problem with base classes for coordinate-frame classes needing to have `name`

See original GitHub issue

A recent code change in #11090 is causing errors in SunPy:

https://github.com/astropy/astropy/blob/87df980318eac43850a3add1e5f32286dad9d723/astropy/coordinates/baseframe.py#L289-L297

We have a base class for a frame that does not have a name attribute, so the base.name access produces an error. It’s easy enough to add a dummy name attribute to “fix” this on our side, but presumably the Astropy code needs some protection?

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

adrncommented, Nov 27, 2020

Ah, yes, an oversight on my part - oops! I’ll submit a follow-up PR now, and add a regression test.

0reactions

mhvkcommented, Nov 29, 2020

fixed by #11101

Top Results From Across the Web

Using and Designing Coordinate Frames

Customizing Frame Component Names¶. First, as mentioned in the point (1) above, some frame classes have special names for their components. For example,...

Astropy: Inititializing a user-defined Coordinate Frame

I calculate the transformatin matrix and give it as an argument for the new frame. But I get an error. Here is the...

Source code for sunpy.coordinates.metaframes

So each type of frame needs its own distinct rotated-Sun frame class. ... A frame that applies solar rotation to a base coordinate...

Chapter 3. Coordinates and Transformations

Assuming a coordinate frame is represented with respect to an incorrect base frame. Applying a coordinate transform to a quantity not represented with...

Chapter 3 – The Classical Orbital Elements (COEs)

So far, we have learned to describe where satellites are in orbit by it ... We will first introduce the coordinate frame used...