question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Record data size in the WCS object

See original GitHub issue

It is clear that there are practical reasons to have a record of the original data size in the WCS object. This in the past has been recorded in public attributes naxis1 and naxis2 and subsequently in the private _naxis1 and _naxis2. There’s along thread on why this should or should not be done in #4662. More recently #5411 expanded this attribute to more than 2 axes. It also broke the ability to set the private attributes which was subsequently fixed in #5454 as a stop gap measure.

We need to fix this permanently starting with v 1.3. There are two proposed ways to do it.

  1. Add public naxisj attributes, populated by the FITS header NAXISj keywords.
  2. Introduce a subclass of WCS which adds those and leave the original WCS to represent strictly the FITS WCS standard and nothing more.

Either way a deprecation process will accompany the change.

The purpose of this issue is to collect votes. I don’t want to start a new long discussion. Keep in mind that #4662 is available for reference and only share new arguments.

Since 1.3 is approaching we need to make a fast decision. So please share your preference here and volunteer for the work if possible.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

2reactions
ndencommented, Nov 4, 2016

I support #1 of the two choices for reasons I mentioned in #5454.

In addition I want to mention that we already deviated from the FITS standard by adding the d2im distortion.

1reaction
mcaracommented, Nov 24, 2016

@MSeifert04 I think the “long discussion” was in https://github.com/astropy/astropy/issues/4669

Read more comments on GitHub >

github_iconTop Results From Across the Web

Source code for astropy.wcs.wcs
Wcsprm ` object) # STDLIB import builtins import copy import io import itertools ... based on the WCS keywords and supplementary data read...
Read more >
HCL Commerce Search performance tuning
The size of each queryResultCache is 4 bytes per docId (int) reference x queryResultWindowSize, for a value of 144 bytes. Allocate 10 M...
Read more >
astropy.wcs: access to NAXIS1 and NAXIS2 · Issue #4669
Hi, I am using astropy.wcs and I think that NAXIS1, NAXIS2 are not easily accessible although ... Record data size in the WCS...
Read more >
WCS — MPDAF 3.6.dev30+g42ea168 documentation
The WCS class manages the world coordinates of the spatial axes of MPDAF images, using the pywcs package. Note that MPDAF images are...
Read more >
Tutorial wcs module — Kapteyn Package (home)
Support for spatial and spectral data; Support for 'mixed' coordinates; Support for conversions between different celestial systems; Objects have useful ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found