Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Revisit xpassed tests and remove xfail from them

See original GitHub issue

For example, there are 3 xpassed tests in https://travis-ci.org/astropy/astropy/jobs/283303458 and https://ci.appveyor.com/project/Astropy/astropy/build/1.0.8822 , respectively (probably the same ones). We should remove xfail from those because they are no longer failing.

astropy\table\tests\test_mixin.py .....................................sss.s.s...................................................X.............
astropy\table\tests\test_operations.py .......x...x.x.x...........x.....x.......................x...xXX.x.........................x.............

Hint: Using this setting turns any xpass into a failure (ref: https://docs.pytest.org/en/latest/skipping.html).

[tool:pytest]
xfail_strict=true

Issue Analytics

State:
Created 6 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

2reactions

mhvkcommented, Oct 13, 2017

Closing, since the passing tests are now all enabled! (And crossing fingers that they continue to pass…)

1reaction

bsipoczcommented, Oct 12, 2017

So the 2 xpassing one is due to the heisenbug in operations: https://github.com/astropy/astropy/issues/6291 It’s great that it’s passing, but we need to make sure it’s indeed gone for good.

In there, it’s suggested (https://github.com/astropy/astropy/issues/6291#issuecomment-312958701) that running the test as pytest astropy/table/tests/test_operations.py --pdb -sv -k test_col_meta_merge_inner always makes it fail, but it’s still xpasses for me now on master, but also on 2.0…