Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Inconsistent tables returned by DAOStarFinder and IRAFStarFinder

See original GitHub issue

Currently, DAOStarFinder and IRAFStarFinder says that it returns table containing specific columns. For example, see this link for DAOStarFinder. However, when there is a problem or no stars are found, instead of returning an empty table with specified columns, these functions return a really very very empty table.

This leads to issues such as https://github.com/spacetelescope/jwst/issues/2716 or, to look directly at the code: https://github.com/spacetelescope/jwst/blob/d7daa6c9cc60fc9870add2950ca06a424056db28/jwst/tweakreg/tweakreg_catalog.py#L59

Specifically, code that relies on the presence of advertised columns will crash. In my opinion, these two classes should be consistent in the format of returned tables.

Issue Analytics

State:
Created 5 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

larrybradleycommented, Oct 29, 2018

@eteq Yes, I’ve been discussing this and other deep philosophical thoughts on the meaning of emptiness offline with @mcara and he’s convinced me. 😄

0reactions

larrybradleycommented, Oct 30, 2018

Closed by #758

Top Results From Across the Web

DAOStarFinder — photutils 1.6.0 - Read the Docs

IRAFStarFinder always uses a 2D circular Gaussian kernel, while DAOStarFinder can use an elliptical Gaussian kernel. IRAFStarFinder calculates the objects' ...