Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix circular references in AtlasMap UI

See original GitHub issue

The following circular dependencies have been found. This might lead to scenarios where a particular dependency is imported as undefined from and import { ... } from '...' statement:

src/app/lib/atlasmap-data-mapper/common/data.mapper.util.ts -> src/app/lib/atlasmap-data-mapper/models/config.model.ts -> src/app/lib/atlasmap-data-mapper/models/document.definition.model.ts -> src/app/lib/atlasmap-data-mapper/common/data.mapper.util.ts
src/app/lib/atlasmap-data-mapper/components/document.definition.component.ts -> src/app/lib/atlasmap-data-mapper/components/line.machine.component.ts -> src/app/lib/atlasmap-data-mapper/components/document.definition.component.ts
src/app/lib/atlasmap-data-mapper/components/line.machine.component.ts -> src/app/lib/atlasmap-data-mapper/components/document.definition.component.ts -> src/app/lib/atlasmap-data-mapper/components/line.machine.component.ts
src/app/lib/atlasmap-data-mapper/models/config.model.ts -> src/app/lib/atlasmap-data-mapper/models/document.definition.model.ts -> src/app/lib/atlasmap-data-mapper/models/field.model.ts -> src/app/lib/atlasmap-data-mapper/models/config.model.ts
src/app/lib/atlasmap-data-mapper/models/document.definition.model.ts -> src/app/lib/atlasmap-data-mapper/models/field.model.ts -> src/app/lib/atlasmap-data-mapper/models/document.definition.model.ts
src/app/lib/atlasmap-data-mapper/models/field.model.ts -> src/app/lib/atlasmap-data-mapper/models/document.definition.model.ts -> src/app/lib/atlasmap-data-mapper/models/field.model.ts

Issue Analytics

State:
Created 6 years ago
Comments:6 (1 by maintainers)

Top GitHub Comments

1reaction

pleacucommented, Feb 5, 2018

@deeleman - Hey Pablo - Paul here (@pleacu) - I was looking at this trivial fcn:

https://github.com/atlasmap/atlasmap/blob/master/ui/src/app/lib/atlasmap-data-mapper/common/data.mapper.util.ts#L45

It’s causing a circular dependency in several components - I was considering moving it to config.model.ts since it’s generating a config.model specific error - wdyt???

0reactions

pleacucommented, Feb 26, 2018

https://github.com/atlasmap/atlasmap/pull/306

the dependency stack goes: lineMachine > docDefInput/ docDefOutput > lineMachine When you scroll the ‘Sources’ or ‘Targets’ document-definition it’s necessary to adjust the line mappings. Instead of calling the lineMachine directly (set up via Angular input) the docDef code now throws a custom event which the lineMachine catches in order to redraw the mapping lines.