Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug] `deepPreserveProps` results wrong modifier configuration

See original GitHub issue

Hi. This is a bug report.

Here in this commit you uniqueByName the modifiers that I pass into…

https://github.com/atomiks/tippyjs-react/commit/7198256fe41c8bb347a3aed4f677b8b01dc7629c#diff-3274f1a37032fb0ae4e2823def0007c634e869ae0dfc304ff6a12c36513c3a52R55

And while fixing #264, this function will be called whenever an update is made.

If I have

popperOptions = {
  modifiers: [
    {name: "flip", enabled: true},
    {name: "flip", enabled: false}
  ]
}

deepPreserveProps unique them by their name so I got

popperOptions = {
  modifiers: [
    {name: "flip", enabled: true},
  ]
}

… but actually what I want is

popperOptions = {
  modifiers: [
    {name: "flip", enabled: false}
  ]
}

Thanks.

Issue Analytics

State:
Created 3 years ago
Comments:7 (6 by maintainers)

Top GitHub Comments

1reaction

atomikscommented, Mar 9, 2021

@KubaJastrz it already is (they get merged). The problem here is just fixing a memory issue with lots of modifiers being re-added when the instance gets updated. Actually the objects might be the same reference, so we could dedupe with a map instead

0reactions

atomikscommented, Mar 10, 2021

So we can’t dedupe with a map, there’s an example in the demo where the reference is always different (in the JSX), but stringify should work in almost all cases, but I’ve merged a fix