rev issue: index.html not updated

I’m submitting a bug report

• Library Version: 0.25.0

Please tell us about your environment:

• Operating System: Windows [10]

• Node Version: 6.9.2

• NPM Version: 4.3.0

• Browser: all

• Language: all

Current behavior: If rev is enabled in aurelia.json, the bindle revisions are generated but index.html is not updated according to that.

Expected/desired behavior: It should replace the index.html like in previous version. I’ve looked at the source and it looks like index is replaced before the revisioned filename is generated. If I change the order, it works fine.

Original bundle.js (line: 182)

      if (loaderOptions.configTarget === this.config.name) {
        //Add to the config bundle the loader config and change the "index.html" to reference the appropriate config bundle
        concat.add(undefined, this.writeLoaderCode(platform));
        contents = concat.content;
        let outputDir = platform.baseUrl || platform.output; //If we have a baseUrl, then the files are served from there, else it's the output
        if (platform.index) {
          this.setIndexFileConfigTarget(platform, path.posix.join(outputDir, bundleFileName));
        }
      }

      if (buildOptions.rev) {
        //Generate a unique hash based off of the bundle contents
        this.hash = generateHash(concat.content);
        bundleFileName = generateHashedPath(this.config.name, this.hash);
      }

Modified version working as expected:

      if (buildOptions.rev) {
        //Generate a unique hash based off of the bundle contents
        this.hash = generateHash(concat.content);
        bundleFileName = generateHashedPath(this.config.name, this.hash);
      }

      if (loaderOptions.configTarget === this.config.name) {
        //Add to the config bundle the loader config and change the "index.html" to reference the appropriate config bundle
        concat.add(undefined, this.writeLoaderCode(platform));
        contents = concat.content;
        let outputDir = platform.baseUrl || platform.output; //If we have a baseUrl, then the files are served from there, else it's the output
        if (platform.index) {
          this.setIndexFileConfigTarget(platform, path.posix.join(outputDir, bundleFileName));
        }
      }

[AStoker]

That’s pretty much what I did (slightly modified). Check out the PR referenced: https://github.com/aurelia/cli/issues/515

[tdamir]

@AStoker Thanks for the fix!