error TS1110: Type expected
See original GitHub issueI’m submitting a bug report
- Library Version: 1.5.0 and 1.5.1
Please tell us about your environment:
-
Operating System: OSX 10.x and Linux Ubuntu
-
Node Version: 10.14.2
-
NPM Version: 6.6.0
-
JSPM OR Webpack AND Version Webpack
-
Browser: not relevant, bug is in building process of other library dependent of this one
-
Language: TypeScript 3.6.4 (also tested with older versions of TS)
Current behavior: Since the new typing definition, we encountered issues trying to build plugins and projects that depend on aurelia-dependency-injection. For exemple, trying to build aurelia-ux project, we get the error:
../../node_modules/aurelia-dependency-injection/dist/aurelia-dependency-injection.d.ts(67,5): error TS1110: Type expected.
[3] ../../node_modules/aurelia-dependency-injection/dist/aurelia-dependency-injection.d.ts(67,5): error TS1110: Type expected.
[4] ../../node_modules/aurelia-dependency-injection/dist/aurelia-dependency-injection.d.ts(67,5): error TS1110: Type expected.
Expected/desired behavior: No error when building projects that depend on aurelia-dependency-injection
- What is the motivation / use case for changing the behavior? I’m stuck in several projects due to this bug. I can force projects that have direct dependency to stick with 1.4.2 but it becomes complicated when I work on projects that have dependency to aurelia-dependency-injection through other dependencies…
See Aurelia Discourse discussion here: https://discourse.aurelia.io/t/contributing-to-aurelia-ux/3023
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (6 by maintainers)
@DrSammyD Would you be able to help us resolve this?
@bigopon I mean, it must have or the this wouldn’t have passed PR checks and this…
https://github.com/aurelia/dependency-injection/blob/98c00441a4a9fe5224e8bd6ecd9fbcac4072643d/dist/aurelia-dependency-injection.d.ts#L65-L68
… wouldn’t have ever been generated when compiling with typescript and running the tests. https://github.com/aurelia/dependency-injection/blob/98c00441a4a9fe5224e8bd6ecd9fbcac4072643d/package.json#L35 https://github.com/aurelia/dependency-injection/blob/98c00441a4a9fe5224e8bd6ecd9fbcac4072643d/package.json#L103
So the issue only shows up when old typings conflict with the new ones? Should the other projects update to the new typings?
Would this fix actually be generically fix or are we going to have to continually change these typings to match what other projects are expecting?