Python: Working with classes and style_class

Hello,

I’m having issue with the python implementation to define style_classes and classes for streams.

1. Defining classes on a stream, for example in the circle scenario:

    builder.primitive('/circle').circle([0.0, 0.0, 0.0], self._radius).classes('Bike')

To fix this i had to change the function _format_primitive in primitive.py: from :

    base.classes = self._classes

to :

    [base.classes.append(cls) for cls in  self._classes]

Now this seems to work to apply the classe in the output at least. Now comes the styling for that class. My understanding is that i should be able to do this by building the metadata like this :

    builder.stream("/circle")\
    .coordinate(xviz.COORDINATE_TYPES.IDENTITY)\
     .stream_style({'fill_color': [200, 0, 70, 128]})\
    .category(xviz.CATEGORY.PRIMITIVE)\
    .type(xviz.PRIMITIVE_TYPES.CIRCLE)\
    .style_class("Car", {'fill_color': [200, 200, 70, 128]})\
    .style_class("Bike", {'fill_color': [0, 200, 70, 128]})

I was kinda of able to at least not make it crash by:

1. Adding the build_class_style function in base_builder.py

    def build_class_style(name, style):
        '''
        Create StyleObjectValue from dictionary. It basically deal with list of bytes.
        '''
        return StyleClass(name=name, style=build_object_style(style))

1. Replacing the function style_class in metadata.py by this :

    from xviz_avs.builder.base_builder import build_class_style
    (...)
    def style_class(self, name, style):
        if not self._stream_id:
            self._logger.error('A stream must set before adding a style rule.')
            return self

        self._temp_stream.style_classes.append(build_class_style(name, style))
        return self

1. Results:

Well, this is where it gets rough for me because my understanding of protobuf still sucks. The result i get is that the class i define for my circle is now visible in the circle tool tip like it should be, but the circle is now fully white.

I hope everything is clear. Any help is welcome on this.

[twojtasz]

Hitting a test failure i’m fixing first then will release

[twojtasz]

I’ll try to get a release out today, but not until this evening.

On Fri, Jul 10, 2020 at 11:51 AM Kevin Greene [e-mail] wrote:

Thank you for the quick review cycle!

Would you guys mind doing a minor release to pypi with this bug fix? that way I can just bump the version number instead of having to package a wheel myself to get this in. I’m using it now

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/uber/xviz/issues/593#issuecomment-656830283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALUBXGFPPARWKBRFACP2F3R25PMVANCNFSM4NEYT4QQ .