Fix for Issue #50 not released for over two years
See original GitHub issueCan you make a new release that fixes #50 (PR #52)? The issue has been solved, but unreleased, since Jul 18, 2017…
I just ran into this issue again, trying to sign a compressed payload: https://runkit.com/embed/mnbqn7bakltj
const pako = require('pako');
const jws = require('jws');
//function copy pasted from https://github.com/brianloveswords/node-jws/blob/master/lib/sign-stream.js#L8
function base64url(buf) {
return buf
.toString('base64')
.replace(/=/g, '')
.replace(/\+/g, '-')
.replace(/\//g, '_');
}
const payload = Buffer.from(
pako.deflateRaw('asdfasdfasdfasdf') //returns a Uint8Array
);
//expected: "SyxOSUtEwgA"
console.log(
base64url(
payload
)
);
//actual: "SyxOSUtE77-9AA"
console.log(
jws.sign({
header: { alg: 'none' },
payload,
encoding: 'utf8'
}).split('.')[1]
);
Issue Analytics
- State:
- Created 4 years ago
- Reactions:2
- Comments:6
Top Results From Across the Web
401(k) Plan Fix-It Guide - Eligible employees weren't ... - IRS
Two ways to credit service to an employee: Hours of service: A 401(k) plan may not require more than a year of service...
Read more >Great Resignation or Not, Compensation Won't Fix Everything
Brian Kropp, Gartner Distinguished VP, predicts that companies will need to plan for a year-over-year turnover rate that is 50% to 75% ...
Read more >Erectile Dysfunction After Prostate Cancer
Within one year, about 40 to 50% of men will have returned to their pre-treatment function. After two years, about 30 to 60%...
Read more >FACT SHEET: Executive Order on Promoting Competition in ...
The rate of new business formation has fallen by almost 50% since the ... the number of cases brought in just two years—enforcement...
Read more >Fact Sheet #23: Overtime Pay Requirements of the FLSA
An employee's workweek is a fixed and regularly recurring period of 168 hours -- seven ... Averaging of hours over two or more...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
This library is clearly no longer being actively maintained, whereas
jose
is.@panva @dschenkelman do you know what the plan is for this library? Personally I think it should be deprecated and people pointed to
jose
You mean no longer providing free development services? No longer pushing regular breaking changes? Sounds like a feature, not a flaw.
People judge tech requirements according to different requirements, some of which don’t include keeping up with every latest idea or proposal. 2 to 4 years between releases is completely reasonable for a mature library, such as
jws
, that has completed what it set out to implement.The maintenance headaches with these kinds of libraries once they go mature is migrating them between package management systems and getting them loaded up in compilers and emulators. That tends to be more systems maintenance work than library programming.
So, as far as I can tell, the programming work was completed for #50 by way of the open source community, and it was only the publication process that broke down. But Microsoft has stepped in and provided an alternative.
Seems like it’s being maintained to me. Responsibilities are organized differently than they used to be, though, and being managed by the open-source community and Microsoft. Which is sort of the intent of open-source in the first place. ¯\(ツ)/¯