User expired property always true

I recently ran into an issue where the user expired property was always true even just after receiving a new token from the identity server.

The current User.test.ts passes but if it is updated to use jest mock timers, it fails.

Example:

import { User } from "./User";

describe("User", () => {
    beforeEach(() => {
        jest.useFakeTimers(); // changed from jest.spyOn
    });

    afterEach(() => {
        jest.restoreAllMocks();
    });

    describe("expired", () => {
        it("should calculate how much time left", () => {
            const subject = new User({ expires_at: 100 } as never);
            expect(subject.expired).toEqual(false);

            // act
            jest.advanceTimersByTime(100); // changed from "now += 100"

            // assert
            expect(subject.expired).toEqual(true);
        });
    });

[kherock]

@pamapa that code removed in the diff wasn’t setting expires_in, it was a redundant assignment ensuring that expires_in is stored as a number as opposed to a string. I removed it since we already cast it as a number in the setter.

The actual assignment occurs in the Object.assign when the code is exchanged: https://github.com/authts/oidc-client-ts/blob/8bf2b68629d9b48d79f28c8cfc88db2d5000d5b6/src/ResponseValidator.ts#L220-L228

The other one for refresh tokens is here: https://github.com/authts/oidc-client-ts/blob/8bf2b68629d9b48d79f28c8cfc88db2d5000d5b6/src/OidcClient.ts#L171-L177

[pamapa]

As changing the time (in unit-test) after the expires_at was calculated has no impact on the expires_at i will soon close this issue, unless you report more info…