Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider Adding an onEndColumnResize prop to <BaseTable />

See original GitHub issue

We’re starting to use react-base-table on Shotgun. One of the things we’re working on is saving column sizes after resizing them. We have this functionality in our current grid, but need to port this functionality to our new grid that is using <BaseTable />. The BaseTable component has an onColumnResize prop, but in our case, we really only want to save settings once the column is finished resizing. I have a PR that adds an onEndColumnResize prop to <BaseTable /> for columns that are resizable.

Is this something you would consider adding to <BaseTable />?

Issue Analytics

State:
Created 4 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

nihgwucommented, Sep 24, 2019

included in v1.9.0

1reaction

nihgwucommented, Sep 20, 2019

I agree with your requirement on the resize end callback, problem is that we may have to add the resize start callback accordingly in the future, and I think onColumnResize is similar to onScroll, we don’t have onScrollStart and onScrollEnd either, as we can detect them via onScroll, but on the other hand, adding onColumnResizeEnd would make it more straight forward