Private field naming convention

In this issue I’d like to align the private field name convention in our project.

I’ve found that in one places we prefix private fields with underscore, while in other we don’t. That is a pretty confusing and we should align the single styling for this project.

Usually, I prefer to start private fields with the underscore character:

private class SomeClass
{
    private readonly int _someValue;

    public SomeClass(int value)
    {
        this._someValue = value;
    }
}

However I would be fine if we agree to live without them (like most of the code is written in kernel) as we enforce the this keyword (so it’s clear that it’s the field):

private class SomeClass
{
    private readonly int someValue;

    public SomeClass(int value)
    {
        this.someValue = value;
    }
}

@moodmosaic @adamchester Do you have any opinion regarding the naming convention? I’m fine with whatever we follow - the only wish is to have a consistency.

[zvirja]

Well, I don’t believe in that 😃 However, who knows… 😏

[moodmosaic]

It was quite surprising, but internally they follow a convention to prefix fields with my - like myManager, myRepository.

Sounds like they’re coming from VB? 😉