Suggestion: follow the "Arrange Act Assert" style for tests

Currently our tests follow the clumsy Four-Phase Test style to describe the test body. I don’t like that at all, as it looks like some old-school stuff which doesn’t play nice with xUnit. My concerns:

• The // Teardown phase is always empty in xUnit tests as it creates a sut per test, without need to restore it.
• The // Fixture setup, // Exercise System and // Verify Outcome looks too verbose, while // arrange, // act and // assert are more laconic. If you don’t create test from a template, it’s much simpler to write those words (it’s always hard to write exercise without typos 😅).

Therefore, @moodmosaic if you don’t have any strong objections (I hope you don’t), I would like to switch us to 3 phase tests and use it all our the tests. It will allow me to feel satisfaction during the test creation, rather than pain 😖

[zvirja]

Usually I use // Act & Assert as it looks more concise and cool 😎 Unless @moodmosaic has concerns, I’d prefer to follow that style 😉

[zvirja]

Great that it worked! 👍

how do I associate the branch i’m working on in my forked repo to this ticket?

I’d suggest to look at this article, the workflow is well described there: https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request

Basically, you don’t need to associate a branch with this issue. Rather, you create a Pull Request and simply mention this issue in the body (e.g. see this one).