Support async operation in ValueResolver natively

Currently I have the following code:

public class OrderNumberResolver : ValueResolver<Order, int>
{
    private readonly IOrderService _service;

    public OrderNumberResolver(IOrderService service)
    {
        _service = service;
    }

    protected override int ResolveCore(Order order)
    {
        return Task.Run(async () => await _service.GetOrder(order.OrderId))
                    .Result
                    .OrderNumber;
    }
}

But it would be nice to have something like that:

public class OrderNumberResolver : ValueResolver<Order, int>
{
    private readonly IOrderService _service;

    public OrderNumberResolver(IOrderService service)
    {
        _service = service;
    }

    protected override async Task<int> ResolveCoreAsync(Order order)
    {
        var order = await _service.GetOrder(order.OrderId);
        return order.OrderNumber;
    }
}

[adamhathcock]

This is what I came up with: https://github.com/Narochno/Narochno.AsyncMapper

People seem to disagree that I should need to do this at all. Composing a domain object from multiple sources feels like a valid use case and some of those sources would need to be async.

[jbogard]

Well that makes two of us!

On Sat, May 14, 2016 at 11:36 AM, Alexander Batishchev < [e-mail]> wrote:

I’m not really familiar with the internal (context, etc.) so wondering is the right way to do async.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/AutoMapper/AutoMapper/issues/1226#issuecomment-219229927