bug in mongoose.Types.ObjectId.isValid()

bug in mongoosejs 6.1.6 version:

ObjectId.isValid validates an Object with prop id as a valid ObjectId: mongoose.Types.ObjectId.isValid({ id: '580e0797bb495f0a200e91ad' }) // true

But in 6.1.5 this is an invalid ObjectId mongoose.Types.ObjectId.isValid({ id: '580e0797bb495f0a200e91ad' }) // false

[maximilianschmid]

@Maximusya thx for the help.

re-checked and found that the isValid changed behaviour from bson@4.6.0 to bson@4.6.1

❯ npm ls bson
planfred-server@34.0.1 /Users/milian/extendedbrain/planfredapp2020/server
├── bson@4.6.0 
└─┬ UNMET PEER DEPENDENCY mongoose@6.1.6
  ├── bson@4.6.0  deduped
  └─┬ mongodb@4.2.2
    └── bson@4.6.0  deduped

npm ERR! peer dep missing: mongoose@^5.6.4, required by mongoose-lean-defaults@2.0.1
❯ node test.js
{ id: '580e0797bb495f0a200e91ad' } mongoose.Types.ObjectId.isValid false

So the issue is caused by bson npm module.

This PR causes the change in the isValid behaviour: https://github.com/mongodb/js-bson/pull/475

isValid now also accepts ObjectIdLike type, which matches an object like { id: ‘580e0797bb495f0a200e91ad’} 580e0797bb495f0a200e91ad

Defined in file on line 13: https://github.com/mongodb/js-bson/blob/master/src/objectid.ts

[vkarpov15]

@maximilianschmid can you please elaborate why this is a breaking change? The intent of isValid() and isValidObjectId() is to check whether a value is something that can be converted to an ObjectId, and growing the set of objects that can be converted to ObjectIds is at worst a semver minor. We can consider explicitly avoiding casting { id: <string> } as an ObjectId if that causes problems.

In the meantime, as per @Uzlopak 's suggestion, we’ll make isValidObjectId() consistent with isValid(). There’s no reason for us to mix/match rules as to what is a valid ObjectId anymore.