Lodash _.set or Object.defineProperty is not working with subschema

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Mongoose version

6.1.7

Node.js version

14.15.4

MongoDB server version

4.3.1

Description

When using lodash to set a property in a sub schema, mongoose don’t detect it as update and when doing a save, the object is not updated. After deeping in lodash, it seems that it’s because we are using Object.defineProperty.

https://github.com/lodash/lodash/blob/master/.internal/baseAssignValue.js#L10

Steps to Reproduce

/* eslint-disable no-console */
const mongoose = require('mongoose');
const _ = require('lodash');

main().catch((err) => console.log(err));

async function main() {
  const blockSchema = new mongoose.Schema({
    type: String,
    value: String,
  }, { _id: false });

  const descriptionSchema = new mongoose.Schema({
    en: [blockSchema],
    fr: [blockSchema],
  }, { _id: false });

  const mainSchema = new mongoose.Schema({
    meta: {
      message: descriptionSchema,
    },
  });
  const Main = mongoose.model('Main', mainSchema);

  await mongoose.connect('mongodb://localhost:27017/test');

  const foo = await Main.create({
    meta: {
      message: {
        fr: [
          { type: 'text', value: 'Ceci est un test bar' },
        ],
      },
    },
  });

  const fooNewly = await Main.findById(foo._id);
  const description = fooNewly.meta.message;
  // *************************

  // You can use the lodash version or the Object version as you want

  // Version 1
  _.set(description, 'en', [
    { type: 'text', value: 'This is a test zoz' },
  ]);
  _.set(fooNewly, 'meta.message', description);

  // Verison 2
  /*
  Object.defineProperty(description, 'en', {
    configurable: true,
    enumerable: true,
    value: [
      { type: 'text', value: 'This is a test zoz' },
    ],
    writable: true,
  });
  Object.defineProperty(fooNewly, 'meta.message', {
    configurable: true,
    enumerable: true,
    value: description,
    writable: true,
  });
  */

  // Working version
  /*
  description.en = [
    { type: 'text', value: 'This is a test zoz' },
  ];
  fooNewly.meta.message = description;
  */

  // *************************

  console.info({ modifiedPaths: fooNewly.modifiedPaths() });
  await fooNewly.save();

  const fooUpdated = await Main.findById(foo._id);
  console.info({ objectFr: fooUpdated.meta.message.fr.toObject() });
  console.info({ objectEn: fooUpdated.meta.message.en.toObject() });
}

Expected Behavior

The mongoose model should be updated and the path should be mark as modified to be able to be saved.

[hasezoey]

i think defineProperty is not detectable like a get/set would be, and could only be detected when (forcibly) comparing a saved state with the current state, which is a approach mongoose currently does not use (from what i know)

the workaround for now would be to manually mark it as modified doc.markModified('path.to.property') (in your case fooNewly.markModified('meta.message'))

[github-actions[bot]]

This issue was closed because it has been inactive for 19 days since being marked as stale.