Model.update(...).catch is undefined

Consider the following:

    Subscription.update({
      _id: { $not: subscription._id },
      startDate: { $lt: today },
      endDate: { $gt: newEndDate }
    }, {
      $set: { endDate: newEndDate }
    }).catch(errorHandler);

This complains that Subscription.update(...).catch is undefined.

Whereas calling it after a save() operation on an item works fine:

user.save().catch(errorHandler);

Also note that I am using Bluebird promises:

mongoose.Promise = require('bluebird');

Mongoose version is 4.4.19.

[adamreisnz]

Well, I think that’s maybe more of a personal opinion 😃

I don’t find it trivial at all, and there are many use cases for me to only use .catch and not have a .then, for example when doing some background updating of data which doesn’t need to send back a response, but does need error handling in case it goes wrong.

I find it much cleaner to write .catch(doSomething) than something like .then(null, doSomething), as it makes it easier to distinguish and separate success handlers and failure handlers and makes the code easier to read. I find then...catch pretty much analogous to a try...catch.

Also, from my usage experience it has been around for quite a while now and most promise libraries implement the method, as well as .finally(), which in my opinion is also a must have to avoid code duplication in certain circumstances.

If you’d want me to make a PR for this let me know, I’ll be happy to look into it.

[adamreisnz]

Thanks, I’ll try to look into it this week 😃