Throw clean error if save() called in parallel on same doc instance

I have seen a few issues closed already regarding the #save() method and swallowing of exceptions. I’ve got this happening at the moment with the latest version in npm (4.4.12). Here’s some code:

const giftcard = new Giftcard({ // new instance of the model
  // setting some properties here
});

giftcard.save((err) => {
  if (err) throw new Error(err);
  // this never happens - the callback is never called
});

I can post a more detailed example if required.

Edit: Also, this happens with the promise interface as well, so giftcard.save().then() has the same result.

[niftylettuce]

@mtimofiiv @cwhenderson20 @dodekeract I have just donated over PayPal to @vkarpov15 ([e-mail]) for his time helping me debug this issue. If you have been able to get passed this through our findings please send him some dough! 💸 He deserves it! He spent a ton of time with me, even while he was on his mobile phone he was helping!

[cwhenderson20]

@vkarpov15 I am experiencing this same issue on version 4.4.20. Attempting to call save on my model results in the callback never being called while running the same operation with $__save works just fine.

I am not overwriting promises and I do not have any pre-save (or otherwise) middleware for the model and using mongoose.set("debug", true) does not show anything strange. I have also verified that the document I’m attempting to save does pass validation.

I have additionally attached a connection error handler to the mongoose instance and no errors are reported.

Example:

const appt = new Appointment();
// fill with data here

appt.save((err, doc) => {
    // callback never called
});

const appt2 = new Appointment();
// fill with data here

appt2.$__save({}, (err, doc) => {
    // callback is called
});

For now I will use the private method as I’m not sure of how to proceed otherwise, but if I can give any more information to help with this, please let me know.

Update Similar to @mtimofiiv, console.log-ing the methods $__save and save give me the actual $__save method as defined in model.js and a function called wrappedPointCut, respectively.

Additionally, after modifying my installed version of mongoose (to log when methods are called) and re-running the code, I can see that indeed the $__save method reports that it is being called, while similar logging for save never reports.