[types] Model.create dosnt return array

Do you want to request a feature or report a bug? type-bug

What is the current behavior? await SomeModel.create([doc1, doc2]) dosnt return an array

If the current behavior is a bug, please provide the steps to reproduce. code used:

// NodeJS: 14.15.1
// MongoDB: 4.2-bionic (Docker)
// import { getModelForClass, prop } from "@typegoose/typegoose"; // @typegoose/typegoose@7.4.5
import * as mongoose from "mongoose"; // mongoose@5.11.12

interface ISomeModel extends mongoose.Document {
  param1: string,
  param2: number,
}

const SomeSchema = new mongoose.Schema({ param1: String, param2: Number });
const SomeModel = mongoose.model<ISomeModel>("SomeModel", SomeSchema);

(async () => {
  await mongoose.connect(`mongodb://localhost:27017/`, { useNewUrlParser: true, dbName: "verifyMASTER", useCreateIndex: true, useUnifiedTopology: true });

  const [...docs] = await SomeModel.create([{ param1: "Hello", param2: 1 }]);
  const doc = await SomeModel.create({});


  await mongoose.disconnect();
})();

{
    "compileOnSave": true,
    "typeAcquisition": {
        "enable": true
    },
    "compilerOptions": {
        "experimentalDecorators": true,
        "emitDecoratorMetadata": true,
        "declarationMap": true,
        "outDir": "lib",
        "moduleResolution": "node",
        "target": "es6",
        "module": "commonjs",
        "newLine": "LF",
        "sourceMap": true,
        "removeComments": true,
        "strict": true,
        "allowUnreachableCode": false,
        "pretty": true,
        "declaration": true,
        "lib": [
            "esnext"
        ]
    },
    "include": [
        "src/**/*"
    ]
}

What is the expected behavior? that await SomeModel.create([doc1,doc2]) returns an array

What are the versions of Node.js, Mongoose and MongoDB you are using? mongoose 5.11.12 typescript 4.1.3

would have provided an pr, but didnt find an fix yet

[imduchy]

@hasezoey I’m not sure, hah. I also tried to play around with this but didn’t figure it out.

https://github.com/Automattic/mongoose/blob/c44d521e18d292817a37c9c1623721da52a249f6/index.d.ts#L635

@vkarpov15 shouldn’t the above overload return an array? I can create a PR if so…

create<Z = T | DocumentDefinition<T>>(...docs: Array<Z>): Promise<Array<T>>;

[hasezoey]

actual issue should get fixed by #9890 (didnt test it yet)