question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Numpad decimal separator does not work on IE11 with a keyboard whose numpad decimal key outputs a comma

See original GitHub issue

Current behavior

The numpad decimal separator on german keyboards produces a , (comma). When setting decimalCharacter to , (comma) and digitGroupSeparator to . (dot), the numpad decimal separator on a german keyboard is not recognized as , (comma) in IE11 (although it produces a , (comma) event.char) and thus not allowed as input. It works flawless in current versions of Firefox and Chrome.

It also works when setting decimalCharacterAlternative to . (dot), however, that should not be necessary as per documentation.

Expected behavior

The numpad decimal separator should be accepted as , (comma).

Steps to reproduce the problem

  1. Use autoNumeric version 4.4.0
  2. In the browser Internet Explorer version 11
  3. On the Windows operating system
  4. Then instantiate the autoNumeric object with the following options:
new AutoNumeric(domElement, {digitGroupSeparator: '.', decimalCharacter: ','});
  1. Numad decimal character on german keyboard can not be entered.

Link to live example (ie. Codepen)

The issue is reproducible on the autonumeric home page (http://autonumeric.org/) when scrolling down to the example and selecting the third example provided (the separate examples page can not be used in IE11 either, but that’s a different problem)

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
AlexandreBonneaucommented, Apr 25, 2019

Using your jsfiddle, when I use my numpad . key, I get [NumpadDecimal Delete #46 undefined]. This is under Firefox 67.0b13, with the us_intl keyboard layout (and a Dvorak keyboard). Under Chromium 73, I get [NumpadDecimal #46 undefined].

I checked under Firefox, Chromium, Firefox for android and Chrome for android, and will take your words for Safari and Edge, and indeed event.char is undefined for those main browsers.

I’ll merge @McNetic PR, thank you both for your researches!

I’ll publish the updated version as soon as I manage to fix all the unit and e2e tests that became red after I updated the dependencies :x

1reaction
sbuschcommented, Sep 13, 2019

FYI, a new version 4.5.6 has been released, which includes this fix. Thanks @AlexandreBonneau !

I tested the new release, and can confirm that the fix works for IE 11 and there’s no regression (tested with current version of Firefox)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Interpretation of key of numeric keypad as decimal separator
Consequence: when the decimal separator in local settings is the comma (','), typing on the full stop ('.') key of the numeric keypad...
Read more >
PH10346: CANNOT EDIT FLOAT VALUES USING IE11 ... - IBM
In IBM Doors Next Generation (DNG), when a user attempts to edit float values using IE11 when the decimal separator is a comma....
Read more >
Test Coverage History & Statistics - Coveralls.io
Fix #602 Numpad decimal separator does not work on IE11 with a keyboard whose numpad decimal key outputs a comma ...
Read more >
Dot instead of comma on numerical keyboard - Super User
I use Hungarian QWERTZ layout (102) but Win 10 has no option for having dot on the numpad instead of a comma (Hungarian...
Read more >
Source - GitHub
... see `v4.5.2`)* ### 4.5.6 + Fix #602 Numpad decimal separator does not work on IE11 with a keyboard whose numpad decimal key...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found