--fail-fast keeps running other test files

The test process that encounters the error simply exits if --fail-fast is enabled. Since each file runs in its own process, no other tests from that file are reported after the first failure is encountered.

However, other test processes run to completion. I’m not sure whether to:

• terminate them outright, which prevents any cleanup, even if there are no failures in those processes
• silence their output, which at least means the test output isn’t cluttered with passing tests, but makes it harder to see why ava won’t exit
• shrug and say that this is expected

When running with limited concurrency we’ll also run into this scenario, so we should implement the same behavior. Additionally we mustn’t launch new test processes.

Any thoughts on what to do with processes that are already running?

[novemberborn]

Ah, so finish the currently running, non-failing tests, including their afterEach callbacks. That way most state would be cleared up, though you may see more than one failure in the test output.

We wouldn’t be able to run the after callbacks though — they may assume the failing tests have completed and therefore crash.

[novemberborn]

As part of #1684 I’ll make sure we stop reporting subsequent test results once a test fails, while still letting the currently active tests run to completion.

OK so what I ended up doing is that workers won’t run other serial tests, or (as long as the error occurs early enough) concurrent tests. Tests that have started are run to completion, including hooks, and shown in the test output. If a test fails in one worker AVA will try and interrupt other workers.