Consider adding babel-core to a peerDep like other integrations (+ to @babel/core)
See original GitHub issueFeature Request
We are going to release Babel 7 soon, and right now it’s incompatible with ava since it’s a peerDep (the dependency needs to be updated either way). I understand that it is nicer to have it as a dependency though because it means less installing.
babel-loader
has had babel-core
as a peerDep before, and I moved grunt/gulp/rollup/cli to it as well in v7 beta. The reasoning was just that people were installing v7/v6 in their dependencies. Peer dependencies can be pretty annoying as well (warnings especially if it’s a transitive dependencies) but it seems to make sense for babel-core
and we will try it out? Having to ask this for all the integrations does make me not want to do it though 😛
Also we are going to move to scoped packages soon!
Or is there an option to use a different version already?
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:21 (7 by maintainers)
Seems like a lot of extra work and complexity for little gain. Can’t we just upgrade to Babel 7 in a new AVA version and people that can’t upgrade to Babel 7 yet can just wait on upgrading AVA?
Judging by this thread, I get the impression that using babel7 should just work because ava brings its own babel dep. However, I made an attempt to use babel 7 in a project that uses ava for testing of react components, but even when using just the
@ava/stage-4
babel preset and no inherits of babelrc it fails due to loose option being wrong somewhere. I didn’t look further into it as I just wanted to test out babel7, and wasn’t ready to invest time in issues since its still in beta. Just chiming in that it certainly didn’t work out of the box at least 😃